Anto01 ca25fbdec5 fix: Remove arbitrary aspect ratio validation and add comprehensive pruning diagnostics ...

**Validation Changes (simulation_validator.py)**:
- Removed arbitrary aspect ratio limits (5.0-50.0) for circular_plate model
- User requirement: validation rules must be proposed, not automatic
- Validator now returns empty rules for circular_plate
- Relies solely on Optuna parameter bounds (user-defined feasibility)
- Fixed Unicode encoding issues in pruning_logger.py

**Root Cause Analysis**:
- 18-20% pruning in Protocol 10 tests was NOT validation failures
- All pruned trials had valid aspect ratios within bounds
- Root cause: pyNastran FATAL flag false positives
- Simulations succeeded but pyNastran rejected OP2 files

**New Modules**:
- pruning_logger.py: Comprehensive trial failure tracking
  - Logs validation, simulation, and OP2 extraction failures
  - Analyzes F06 files to detect false positives
  - Generates pruning_history.json and pruning_summary.json

- op2_extractor.py: Robust multi-strategy OP2 extraction
  - Standard OP2 read
  - Lenient read (debug=False)
  - F06 fallback parsing
  - Handles pyNastran FATAL flag issues

**Documentation**:
- SESSION_SUMMARY_NOV20.md: Complete session documentation
- FIX_VALIDATOR_PRUNING.md: Deprecated, retained for historical reference
- PRUNING_DIAGNOSTICS.md: Usage guide for pruning diagnostics
- STUDY_CONTINUATION_STANDARD.md: API documentation

**Impact**:
- Clean separation: parameter bounds = feasibility, validator = genuine failures
- Expected pruning reduction from 18% to <2% with robust extraction
- ~4-5 minutes saved per 50-trial study
- All optimization trials contribute valid data

**User Requirements Established**:
1. No arbitrary checks without user approval
2. Validation rules must be visible in optimization_config.json
3. Parameter bounds already define feasibility constraints
4. Physics-based constraints need clear justification

2025-11-20 20:25:33 -05:00

9.4 KiB

Raw Blame History

View Raw